[PATCH] D133634: [clang] Allow vector of BitInt

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG649a59712ffb: [clang] Allow vector of BitInt (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:3111 Extra.mangleSourceName("__vector"); -Extra.mangleType(QualType(ET, 0), Range, QMM_Escape); +Extra.mangleType(QualType(ET ? static_cast(

[PATCH] D133634: [clang] Allow vector of BitInt

craig.topper added a comment. In D133634#3795044 , @erichkeane wrote: > The CFE Changes look correct, but @eli.friedman/@craig.topper should comment > as to whether this is acceptable. This is acceptable to me. Comment at: clang/lib

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 460958. python3kgae added a comment. Allow BitInt vector for Microsoftmangle and add codeGen tests for BitInt vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D1336

[PATCH] D133634: [clang] Allow vector of BitInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3024 def err_attribute_invalid_vector_type : Error<"invalid vector element type %0">; +def err_attribute_invalid_bitint_vector_type : Error<"invalid vector element type %0, must b

[PATCH] D133634: [clang] Allow vector of BitInt

erichkeane added a subscriber: eli.friedman. erichkeane added a comment. The CFE Changes look correct, but @eli.friedman/@craig.topper should comment as to whether this is acceptable. It still needs a few codegen tests however, to make sure the basic operations work, and that these are passed c

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae added a comment. Thanks for all the comments. I've limit BitInt vector to BitInt with byte-sized and power of 2 NumBits. For the ABI, is it OK to let mangleType of VectorType treat BitInt like other element types, call mangleType of BitInt for the element type part? Repository:

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 460659. python3kgae added a comment. Limit BitInt vector to byte-sized and power of 2 BitInt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634 Files: clang/inclu

[PATCH] D133634: [clang] Allow vector of BitInt

efriedma added a comment. I think the worst of the backend issues with vectors of non-byte-size integers have been resolved? Work on that has progressed slowly for a very long time. There have been a constant stream of issues. (See, for example, D129164 .)

[PATCH] D133634: [clang] Allow vector of BitInt

craig.topper added subscribers: efriedma, craig.topper. craig.topper added a comment. I'm a little nervous about non-byte-sized non-power of 2 elements. The memory layout handling gets a little weird in the backend. @efriedma what do you think? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D133634: [clang] Allow vector of BitInt

erichkeane added a comment. There was no motivation for disabling this other than not wanting/caring enough to define the ABI and writing sufficient tests. While I don't think there is sufficient testing here around ABI/etc, I have no problem with this. Repository: rG LLVM Github Monorepo

[PATCH] D133634: [clang] Allow vector of BitInt

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D133634#3783160 , @python3kgae wrote: > In D133634#3782999 , @xbolva00 > wrote: > >> Mi

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae added a comment. In D133634#3782999 , @xbolva00 wrote: > Missing IR tests. No issues in codegen? > > Very poor description. Why it was disabled? Why we can enable it now? I'm not sure why it is disabled. I guess it is never enabled and just a

[PATCH] D133634: [clang] Allow vector of BitInt

xbolva00 added a comment. Missing IR tests. No issues in codegen? Very poor description. Why it was disabled? Why we can enable it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634 ___

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 459359. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaType.

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, Anastasia, aaron.ballman, bogner. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove check which disable BitInt as