[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae updated this revision to Diff 468731. python3kgae marked an inline comment as done. python3kgae added a comment. Update comment and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

rjmccall added a comment. Okay, this seems fine to me. I think you accidentally removed the word "promotion" from the patch title, though. I assume HLSL also provides `uint16_t`, and you should test the behavior for it. You should also test this for whatever 8-bit types HLSL provides

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae added a comment. In D133668#3847999 , @rjmccall wrote: > If you have `char`, would you want it to promote? Because turning `char` to > `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better > or worse. So if you just