[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

cpplearner added a comment. In D133853#3808674 , @aaron.ballman wrote: > Now I'm wondering why the attribute exists at all. If it's functionally > equivalent to `constexpr` as a keyword, what are the use cases for the > attribute? It appears that

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt abandoned this revision. RIscRIpt added a comment. Closing in favor of https://reviews.llvm.org/D134458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133853/new/ https://reviews.llvm.org/D133853

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. I am new to `arc`, I tried `arc diff --edit --verbatim` as it's said in the docs, but it still created a new revision: https://reviews.llvm.org/D134458 Comment at: clang/lib/Sema/SemaStmtAttr.cpp:296 + // Validation is in

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

h-vetinari added a comment. > Now I'm wondering why the attribute exists at all. If it's functionally > equivalent to `constexpr` as a keyword, what are the use cases for the > attribute? I'm guessing something to do with ABI-compatibility with artefacts produced by their older compilers

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. In D133853#3808669 , @RIscRIpt wrote: > In D133853#3799344 , @aaron.ballman > wrote: > >> It's a conforming extension in older language modes like C++98, where we >> couldn't

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3799344 , @aaron.ballman wrote: > It's a conforming extension in older language modes like C++98, where we > couldn't steal the `constexpr` keyword because it's not reserved, which is > one benefit to it. Does MSVC

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

h-vetinari added a comment. In D133853#3797598 , @RIscRIpt wrote: > I am afraid it would take me some effort to implement semantics of > `[[msvc::no_unique_address]]`, so I'd like to focus only on > `[[msvc::constexpr]]` in current patch. Just for

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. In D133853#3797598 , @RIscRIpt wrote: > In D133853#3795579 , @aaron.ballman > wrote: > >> FWIW, one Microsoft-specific attribute I know people have been asking about >> is

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3795579 , @aaron.ballman wrote: > but my suggestion is to only support `[[msvc::constexpr]]` with the semantic > meaning of `constexpr` Sounds good to me. > It's a good question as to whether we want to support

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

erichkeane added a comment. In D133853#3795579 , @aaron.ballman wrote: > In D133853#3793284 , @RIscRIpt > wrote: > >> In D133853#3792518 , >> @aaron.ballman wrote: >>

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D133853#3793284 , @RIscRIpt wrote: > In D133853#3792518 , @aaron.ballman > wrote: > >>

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3792518 , @aaron.ballman wrote: > I'm wondering what the goal is for these changes. ... Are you intending to > add semantics for these attributes in follow-up patches? To be honest, I wasn't planning to do any of

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. Thank you for the patch! I'm wondering what the goal is for these changes. We don't typically add attributes to Clang that don't have any effect unless there's a very compelling reason to do so. Are you intending to add semantics for these attributes in follow-up

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - 'msvc::no_tls_guard', first appeared in