[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3283f71069a0: Add clang flag equivalent to clang-cl /Zl flag (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 ___ cfe-commits mailing list

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462230. akhuang marked an inline comment as done. akhuang added a comment. Fix flag name in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 Files:

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-runtime-flags.c:101 +// RUN: %clang -### --target=x86_64-windows-msvc -fms-runtime-lib=static \ +// RUN: -fms-omit-default-lib-name -- %s 2>&1 | FileCheck \ +// RUN: -check-prefix=CHECK-MTZl %s

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:2226 +def fms_omit_default_lib : Joined<["-"], "fms-omit-default-lib">, + Group, Flags<[NoXarchOption, CoreOption]>;

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462042. akhuang marked an inline comment as done. akhuang added a comment. Change name of flag, and alias /Zl to this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang added a comment. In D133959#3793283 , @hans wrote: > Could the new flag be marked as an Alias in the tablegen, so that we don't > need to do any code changes for it? It appears before _SLASH_Zl in the file so we'd have to move it out of place.

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans added a comment. Could the new flag be marked as an Alias in the tablegen, so that we don't need to do any code changes for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/include/clang/Driver/Options.td: dll version.}]>; +def fms_omit_default_lib_name : Joined<["-"], "fms-omit-default-lib-name">, + Group, Flags<[NoXarchOption, CoreOption]>, Initially, I'm not entirely sure

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang created this revision. akhuang added reviewers: mstorsjo, hans. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The /Zl flag omits default C runtime library name from obj files. This