EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Maintainers from Apple and FreeBSD gave this the thumbs up.
http://reviews.llvm.org/D13407
___
cfe-commits
EricWF marked an inline comment as done.
Comment at: include/CMakeLists.txt:38
@@ +37,3 @@
+ COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >>
${LIBCXX_BINARY_DIR}/__generated_config
+ DEPENDS ${LIBCXX_SOURCE_DIR}/include/__config
+)
EricWF marked an inline comment as done.
EricWF added a comment.
@eugenis I'll commit this tuesday morning If I don't hear anything over the
weekend (Monday is a holiday for me).
If you rebase the ABI patch to work with this I'll make sure to review it ASAP.
Comment at:
EricWF updated this revision to Diff 37013.
EricWF added a comment.
Make the generated config dependent on the "__config_site" file. It probably
didn't need this but it doesn't hurt to have.
http://reviews.llvm.org/D13407
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
eugenis added a comment.
Thanks. I'll upload the rebase patch on Monday.
Comment at: include/CMakeLists.txt:38
@@ +37,3 @@
+ COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >>
${LIBCXX_BINARY_DIR}/__generated_config
+ DEPENDS
vkalintiris added a subscriber: vkalintiris.
Comment at: include/CMakeLists.txt:9
@@ -7,2 +8,3 @@
PATTERN ".svn" EXCLUDE
+ PATTERN "__config_site.in" EXCLUDE
${LIBCXX_SUPPORT_HEADER_PATTERN}
Kind of silly but I believe that the files used for
EricWF added inline comments.
Comment at: include/CMakeLists.txt:31
@@ +30,3 @@
+# by prepending __config_site to the current __config header.
+# TODO(EricWF) Is it portable to use "cat" and ">>"?
+add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config
eugenis added a comment.
Looks great!
Comment at: include/CMakeLists.txt:31
@@ +30,3 @@
+# by prepending __config_site to the current __config header.
+# TODO(EricWF) Is it portable to use "cat" and ">>"?
+add_custom_command(OUTPUT
EricWF added inline comments.
Comment at: include/CMakeLists.txt:31
@@ +30,3 @@
+# by prepending __config_site to the current __config header.
+# TODO(EricWF) Is it portable to use "cat" and ">>"?
+add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config
rnk added a subscriber: rnk.
Comment at: include/CMakeLists.txt:31
@@ +30,3 @@
+# by prepending __config_site to the current __config header.
+# TODO(EricWF) Is it portable to use "cat" and ">>"?
+add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config
EricWF added a comment.
Cool. I've reached out to some platform maintainers to make sure they don't see
any problems. I'll commit this once I hear back.
http://reviews.llvm.org/D13407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF updated this revision to Diff 36682.
EricWF added a comment.
Use `type` instead of `cat` on windows as suggested by @rnk. @eugenis does this
address your concern?
http://reviews.llvm.org/D13407
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
jroelofs added a comment.
Design doc looks good! I think it captures all the design constraints well, and
the proposed solution satisfies those constraints as far as I am concerned.
Thumbs up from me... but I'll still defer the final 'LGTM' to @mclow.lists.
http://reviews.llvm.org/D13407
EricWF updated this revision to Diff 36457.
EricWF added a comment.
I removed all non-essential changes in order to make this easy and fast to
review. This patch is blocking a number of people so I would like to have this
reviewed soon.
http://reviews.llvm.org/D13407
Files:
CMakeLists.txt
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: cfe-commits.
Hi all,
This patch is a successor to D11963. However it has changed dramatically and I
felt it would be best to start a new review thread.
Please read the design
EricWF added a comment.
Oh, but don't review the design doc too closely. I'm still working on it.
http://reviews.llvm.org/D13407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added subscribers: eugenis, asl, espositofulvio, ed.
EricWF added a comment.
Adding subscribes from the old patch to this one.
http://reviews.llvm.org/D13407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
17 matches
Mail list logo
