[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 added a comment. Fixed in D134653 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134224/new/ https://reviews.llvm.org/D134224 ___ cfe-commits mailing list

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

srj added a comment. This change has broken x86-32 builds, at least on Linux. /usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:136:25: error: static assertion failed: PointerIntPair with integer size too large for pointer 136 | static_assert(IntB

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf35230ae0a69: [clang][modules][deps] Report modulemaps describing excluded headers (authored by jansvoboda11). Changed prior to commit: https://re

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with formatting fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134224/new/ https://reviews.llvm.org/D134224 __

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

Bigcheese added a comment. I think this is fine, but I need to think more about the ModuleDepCollector.cpp change. Comment at: clang/lib/Lex/ModuleMap.cpp:1275 // specified module? - (void) Headers[Header.Entry]; + (void) Headers[Header.Entry].push_back(KH); ---

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 updated this revision to Diff 461432. jansvoboda11 added a comment. Fix failing test by undoing some API changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134224/new/ https://reviews.llvm.org/D134224 Files: clang/include/clang/L

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese, rsmith. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Module map file