[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. yeah I'm ok with that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___ cfe-commits mailing list

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3822028 , @MyDeveloperDay wrote: > I guess the clang-format check might come before any building of the code. +1. > You know if we relex the "Unknown" YAML option, this would go a long way not > only to help us

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. I'm not sure what version of clang-format they use in the premerge checks, I don't know who we contact to get it updated. I guess the clang-format check might come before any building of the code. You know if we relex the "Unknown" YAML option, this would go a

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3817601 , @MyDeveloperDay wrote: > Unfortunately this is causing the failing the "premerge checks" on reviews > likely because this machine is using an earlier version of clang-format Isn't this the case for any new

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. Unfortunately this is failing the "premerge checks" F24716144: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3806667 , @owenpan wrote: > In D134329#3805704 , @sstwcw wrote: > >> Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? > > I was going to take care

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d621398626a: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan added a comment. In D134329#3805704 , @sstwcw wrote: > Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? I was going to take care of them after this patch. Thanks for asking though. Repository: rG LLVM Github

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

sstwcw added a comment. Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, we of all people have to dogfood this stuff.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix braces