This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd4420402927e: [clang] Fix interaction between asm labels and
inline builtins (authored by serge-sans-paille).
Changed prior to commit:
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Please make sure to mark comments as "Done" in phab to help reviewers skip over
stale feedback.
Comment at: clang/lib/CodeGen/CGExpr.cpp:5055-5059
+
serge-sans-paille updated this revision to Diff 462009.
serge-sans-paille added a comment.
Address reviews.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134362/new/
https://reviews.llvm.org/D134362
Files:
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/CGExpr.cpp
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:5057
+if (FD->hasAttr())
+ FDInlineName = FD->getAttr()->getLabel().str();
+else
This is throwing away the ".inline" suffix? Is that intentional?
CHANGES SINCE LAST ACTION
nickdesaulniers added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:5056-5057
+std::string FDInlineName;
+if (FD->hasAttr())
+ FDInlineName = FD->getAttr()->getLabel().str();
+else
I think you could use:
```
if (auto *A =
nickdesaulniers added inline comments.
Comment at: clang/test/CodeGen/asm-label-inline-builtins.c:18-20
+// CHECK-NOT: @vprintf(
+// CHECK-NOT: @__vprintf_chk
+// CHECK-NOT: @vprintf.inline(
please be consistent wrt. the trailing open paren `(`.
Let's add a
aaron.ballman added reviewers: rjmccall, efriedma.
aaron.ballman added a comment.
Adding some more codegen reviewers. Can you add a release note for the fix?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134362/new/
https://reviews.llvm.org/D134362
serge-sans-paille updated this revision to Diff 461893.
serge-sans-paille added a comment.
(rebased on main branch)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134362/new/
https://reviews.llvm.org/D134362
Files:
clang/lib/CodeGen/CGExpr.cpp
serge-sans-paille created this revision.
serge-sans-paille added reviewers: RKSimon, aaron.ballman, nickdesaulniers.
Herald added a project: All.
serge-sans-paille requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
One must pick the same name
