[PATCH] D134394: Update docs about [[likely]] vs. PGO

2022-09-22 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. See also D134456 which affects the behavior here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134394/new/ https://reviews.llvm.org/D134394 ___

[PATCH] D134394: Update docs about [[likely]] vs. PGO

2022-09-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D134394#3808397 , @serge-sans-paille wrote: > While running this small experiment: > https://sergesanspaille.fedorapeople.org/proftest.sh Thank you for the help with testing the assumptions here! Repository: rG

[PATCH] D134394: Update docs about [[likely]] vs. PGO

2022-09-22 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. While running this small experiment: https://sergesanspaille.fedorapeople.org/proftest.sh I get the following output: clang version 16.0.0 (...) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: ... - instrumentation + likely:

[PATCH] D134394: Update docs about [[likely]] vs. PGO

2022-09-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added reviewers: Mordante, aaron.ballman. Herald added a subscriber: wenlei. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. It sounds like these attributes do nothing when PGO is enabled, which is actually (or