[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay added a comment. I am not a user of the MSVC toolchain, so leaving this work to someone working on it is better:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134468/new/ https://reviews.llvm.org/D134468

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

hans added a comment. In D134468#3812846 , @MaskRay wrote: > I am not a Windows driver user. This patch is entirely motivated by Windows > discussions in D131465 and I want to make > `/std:` default rule simple (say,

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay added a comment. I am not a Windows driver user. This patch is entirely motivated by Windows discussions in D131465 and I want to make `/std:` default rule simple (say, clang 16 uses C++17 for every mode for Windows). If the `-fno-threadsafe-statics`

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

thieta added a comment. I think we should define a policy for this. I doubt we have many users on these older versions but I think maybe we should give deprecation messages for at least one release before we drop it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a subscriber: andrew.w.kaylor. aaron.ballman added a comment. Adding clang-vendors for awareness as this has the potential to impact folks vending clang. In D134468#3811882 , @probinson

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

probinson added a comment. These kinds of compatibility changes generally should get a Discourse post for better visibility. Comment at: clang/docs/ReleaseNotes.rst:85 + a version smaller than ``19.0`` is now unsupported. + Or words to that effect. "19.0"

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

STL_MSFT added a comment. A couple of notes/reminders that may help you make a decision here (I have no particular opinion as this doesn't impact how VS and microsoft/STL use Clang): 1. VS 2013's support lifecycle, documented at

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

hans added a comment. I'm conflicted about this. I see where you're coming from, but I could imagine people using clang-cl with old VS versions e.g. to target old Windows. I agree we shouldn't go out of our way to support that, but do we think it's too much effort to keep the functionality we

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

rnk added a subscriber: aaron.ballman. rnk added a comment. There are a lot more hits for `isCompatibleWithMSVC` used with 2015 across the codebase. Do you want to handle them in a follow up? That's fine with me. I would like to get a second opinion before doing this. +@aaron.ballman

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay updated this revision to Diff 462292. MaskRay retitled this revision from "[Driver] Drop MSVC<2015 tweaking" to "[Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19". MaskRay edited the summary of this revision. MaskRay added a comment. . Repository: rG