[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3543 +definition or a return statement. It has no effect on function declarations. +This attribute permits constant evaluation of ``[[msvc::constexpr]]`` functions +in ``[[msvc::constexpr]]

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 540803. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Bump Renamed clang/test/AST/msvc-* to ms-* Tried to improve doc note. Rebased onto one of stable commits from main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 538026. RIscRIpt added a comment. Rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 Files: clang/include/clang/Basic/Attr.td

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

erichkeane added a subscriber: tbaeder. erichkeane added a comment. In D134475#4393035 , @RIscRIpt wrote: > Added diagnostics for [[msvc::constexpr]] virtual > > Regarding [[msvc::constexpr]] constructors, unfortunatelly I cannot find a > reasonable way

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 528112. RIscRIpt added a comment. Added diagnostics for [[msvc::constexpr]] virtual Regarding [[msvc::constexpr]] constructors, unfortunatelly I cannot find a reasonable way to support it. During development I found out about Clang's experimental Constant

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt planned changes to this revision. RIscRIpt marked 2 inline comments as done. RIscRIpt added a comment. > Does it prohibit the inverse? I think this documentation overall needs a > much better description of what the semantics are here, particularly anything > that you found in

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

erichkeane added a comment. Still suspicious about this/whether it models the MSVC implementation correctly, but no real implementation concerns. I REALLY want us to document the attribute extensively however. Comment at: clang/include/clang/Basic/AttrDocs.td:3543