[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

aaron.ballman added a comment. In D134578#3821301 , @ayzhao wrote: > In D134578#3821178 , @ilya-biryukov > wrote: > >> Is this the only thing that blocks D53847 ? >> I suggest to

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2b34789541: Add missing `struct` keyword to the test p2-2.cpp (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ayzhao added a comment. In D134578#3821178 , @ilya-biryukov wrote: > Is this the only thing that blocks D53847 ? > I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu > will have comments we can

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ilya-biryukov added a comment. Is this the only thing that blocks D53847 ? I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu will have comments we can address them in post-commit review. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

erichkeane added a comment. Er... please dont' count that 'accept', let @ChuanqiXu be the approver here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/ https://reviews.llvm.org/D134578 ___

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

erichkeane added subscribers: aaron.ballman, erichkeane. erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thanks for looking into it. I think you're right that it is a mistake that we accepted that without the 'struct' keyword after

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ilya-biryukov added subscribers: ChuanqiXu, ilya-biryukov. ilya-biryukov added a reviewer: ChuanqiXu. ilya-biryukov added a comment. LGTM. I believe the standard is clear here, the declaration inside `export` does not have any special treatment in terms of how it must be parsed. @ChuanqiXu

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on D53847 , I noticed that this test would fail once we started recognizing