[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

nathanchance added a comment. In D134671#3828197 , @craig.topper wrote: > In D134671#3824644 , > @nickdesaulniers wrote: > >> I don't think it's an issue for us to work around downstream, but this did >>

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper added a comment. In D134671#3824644 , @nickdesaulniers wrote: > I don't think it's an issue for us to work around downstream, but this did > regress support for `-mabi=ms` used in UEFI related build scripts. >

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

aaron.ballman added a comment. In D134671#3824868 , @MaskRay wrote: > In D134671#3824672 , @aaron.ballman > wrote: > >> In D134671#3824644 , >> @nickdesaulniers wrote:

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

MaskRay added a comment. In D134671#3824672 , @aaron.ballman wrote: > In D134671#3824644 , > @nickdesaulniers wrote: > >> I don't think it's an issue for us to work around downstream, but this did >> regress

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

aaron.ballman added a comment. In D134671#3824644 , @nickdesaulniers wrote: > I don't think it's an issue for us to work around downstream, but this did > regress support for `-mabi=ms` used in UEFI related build scripts. >

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

nickdesaulniers added subscribers: nathanchance, nickdesaulniers. nickdesaulniers added a comment. I don't think it's an issue for us to work around downstream, but this did regress support for `-mabi=ms` used in UEFI related build scripts. https://github.com/ClangBuiltLinux/linux/issues/1725

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ad006a8f64: [Driver] Prevent Mips specific code from claiming -mabi argument on other… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134671/new/ https://reviews.llvm.org/D134671

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper updated this revision to Diff 463049. craig.topper added a comment. Herald added subscribers: pcwang-thead, s.egerton, simoncook. Address review comments. I didn't test the -march because all of the target I'm familiar with use -march. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper added inline comments. Comment at: clang/lib/Driver/Driver.cpp:637 // accordingly to provided ABI name. - A = Args.getLastArg(options::OPT_mabi_EQ); + A = Args.getLastArgNoClaim(options::OPT_mabi_EQ); if (A && Target.isMIPS()) { arichardson

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

MaskRay added inline comments. Comment at: clang/test/Driver/mabi.c:1 +// RUN: %clang -target i386-unknown-linux -mabi=ms -S %s -### 2>&1 | FileCheck --check-prefix=CHECK %s + `-target ` is legacy. Use `--target=` Repository: rG LLVM Github Monorepo

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

arichardson added inline comments. Comment at: clang/lib/Driver/Driver.cpp:637 // accordingly to provided ABI name. - A = Args.getLastArg(options::OPT_mabi_EQ); + A = Args.getLastArgNoClaim(options::OPT_mabi_EQ); if (A && Target.isMIPS()) { Would it make

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. Herald added subscribers: StephenFan, atanasyan, arichardson, sdardis. Herald added a project: All. craig.topper requested review of this revision. Herald added a subscriber: MaskRay. Herald added a