[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

2022-10-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG41b51007e637: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting (authored by

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

2022-09-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for digging into the rabbit role and the great analysis. It looks good from my side. Re the test case `ID(I TWO 3)` we discussed yesterday, I verified that there is no issue. (we

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

2022-09-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. > However I tried to avoid mixing these with subtle behavior changes, and will > send a followup instead. D134694 if you're interested. I guess I should try to get performance measures though... Repository: rG LLVM Github

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

2022-09-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: ilya-biryukov, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits.