[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003b6033e1b2: [clang] Ensure correct metadata for relative vtables (authored by leonardchan). Changed prior to commit:

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan updated this revision to Diff 468701. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

phosek added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1288-1293 + llvm::Type *ComponentType; + if (UseRelativeLayout(*this)) +ComponentType = Int32Ty; + else +ComponentType = Int8PtrTy; + CharUnits ComponentWidth =

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, tejohnson, pcc. leonardchan added a project: clang. Herald added a subscriber: Prazek. Herald added a project: All. leonardchan requested review of this revision. Prior to this, metadata pertaining to the size or