This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e1c1d6d7287: MSVC AArch64 ABI: Homogeneous aggregates
(authored by dblaikie).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134688/new/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134688/new/
https://reviews.llvm.org/D134688
___
dblaikie added a comment.
Ping on this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134688/new/
https://reviews.llvm.org/D134688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dblaikie marked 2 inline comments as done.
dblaikie added inline comments.
Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:4478-4480
// MSVC Windows on Arm64 considers a type not HFA if it is not an
// aggregate according to the C++14 spec. This is not consistent with
dblaikie updated this revision to Diff 463379.
dblaikie added a comment.
Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134688/new/
https://reviews.llvm.org/D134688
Files:
clang/lib/CodeGen/MicrosoftCXXABI.cpp
rnk added a comment.
Nice! Mostly comment copy edits.
Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:4478-4480
// MSVC Windows on Arm64 considers a type not HFA if it is not an
// aggregate according to the C++14 spec. This is not consistent with the
// AAPCS64,
dblaikie created this revision.
dblaikie added reviewers: hansw, rnk.
Herald added subscribers: mstorsjo, kristof.beyls.
Herald added a project: All.
dblaikie requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes:
Protected members, HFA:
