This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f3d7c2cc770: [clang] Add debug info in
MicrosoftCXXABI::EmitVirtualMemPtrThunk() (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds good to me.
(Ah, I see, that chrome bug actually hit the underlying problem, not even the
verifier constraint - when the constraint is violated & not detected, then code
gets
aeubanks updated this revision to Diff 463669.
aeubanks edited the summary of this revision.
aeubanks added a comment.
update test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134825/new/
https://reviews.llvm.org/D134825
Files:
dblaikie added inline comments.
Comment at:
clang/test/CodeGenCXX/microsoft-abi-member-pointers-debug-info.cpp:13
+
+// CHECK: ![[DBG]] = !DILocation(
+
might be worth checking what location this is, to show it's a good one? (the
code added makes some choice
aeubanks updated this revision to Diff 463661.
aeubanks added a comment.
update test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134825/new/
https://reviews.llvm.org/D134825
Files:
clang/lib/CodeGen/MicrosoftCXXABI.cpp
aeubanks created this revision.
aeubanks added a reviewer: rnk.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://crbug.com/1355639
Repository:
rG LLVM Github Monorepo
