[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

donat.nagy added a comment. Commit rGde2547329b41ad6ea4ea876d12731bde5a6b64c5 accidentally refers to this review, but in fact it belongs to D148355 . Repository: rG LLVM Github Monorepo

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rGa504ddc8bf9d: [analyzer] Initialize regions returned by CXXNew to undefined (authored by Szelethus). Changed prior to commit:

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D135375#3882491 , @Szelethus wrote: > Seems like the issues mentioned above are real, but orthogonal to this patch. > Would it be okay to

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Seems like the issues mentioned above are real, but orthogonal to this patch. Would it be okay to address them in followup patches? @martong @NoQ Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:927 SVal RetVal = State->getSVal(CNE,

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

NoQ added a comment. Yay I'm glad that you got to implement that!! > I'd appreciate if the "storing uninitialized value" was placed inside the > notes about the call to QScopedArrayPointer's constructor. It should not be placed inside the notes about the call to constructor, because it

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong added a comment. I am happy with the change and with the result. However, [[

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong added a comment. In D135375#3849261 , @Szelethus wrote: > Some early results: > >

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Some early results: https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?review-status=Unreviewed=Confirmed%20bug=New=Reopened=Unresolved=on=%2acxxnew_baseline=%2acxxnew_patched=New I'm still waiting on a few projects, but this is something. A few

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

steakhal added a comment. Awesome! Have you measured how often would this change introduce new garbage value warnings? At the other side of the spectrum it could also hide reports, because it sinks the path too soon due to the falsely binding uninitialized value there. WDYT?

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Just a note on the test files -- I've diverged from the usual stance of just changing what the new output is, to modifying the test files. The reason is that reading an undefined value is a fatal error, leading to the analyzer to stop analyzing prematurely, and I

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus created this revision. Szelethus added reviewers: NoQ, martong, steakhal, balazske, isuckatcs. Szelethus added a project: clang. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.