[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson abandoned this revision. royjacobson added a comment. Closing in favor of the much more mature D137302 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. In D135404#3899904 , @njames93 wrote: > I'd also suggest using the `IgnoreUnlessSpelledInSource` traversal kind here. > Given that most of the time these will be instantiated we don't want to warn > and emit a fix for each

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 472660. royjacobson marked 4 inline comments as done. royjacobson added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files:

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

njames93 added a comment. I'd also suggest using the `IgnoreUnlessSpelledInSource` traversal kind here. Given that most of the time these will be instantiated we don't want to warn and emit a fix for each instantiation, Or you could just add `unless(isInTemplateInstantiation())` to your

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. friendly ping @njames93 FWIW I ran this over the LLVM codebase and have seen no crashes or false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 466285. royjacobson added a comment. Addrees CR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files:

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson marked 2 inline comments as done. royjacobson added a comment. In D135404#3842156 , @njames93 wrote: > Why limit this to just the value type traits, makes sense to also support > type type traits. I'd love to, but I can't match against the

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

njames93 added a comment. Why limit this to just the value type traits, makes sense to also support type type traits. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:73 +const auto *RecordQualifier = +cast_if_present( +

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson created this revision. royjacobson added reviewers: njames93, ymandel, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: