This revision was automatically updated to reflect the committed changes.
stuij marked an inline comment as done.
Closed by commit rG95bbe9a19308: [clang][ARM] follow GCC behavior for defining
__SOFTFP__ (authored by stuij).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https
pratlucas accepted this revision.
pratlucas added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135680/new/
https://reviews.llvm.org/D135680
stuij marked an inline comment as done.
stuij added inline comments.
Comment at: clang/test/Preprocessor/init-arm.c:404
+// is specified
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi
-target-feature +soft-float -target-feature +soft-float-abi < /dev/
stuij updated this revision to Diff 468495.
stuij added a comment.
addressed review comment by adding test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135680/new/
https://reviews.llvm.org/D135680
Files:
clang/lib/Basic/Targets/ARM.cpp
clang/
pratlucas added inline comments.
Comment at: clang/test/Preprocessor/init-arm.c:404
+// is specified
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi
-target-feature +soft-float -target-feature +soft-float-abi < /dev/null |
FileCheck -match-full-lines
stuij created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
stuij requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
GCC behavior regarding defining __SOFTFP__ when (implicitly) specifying
-mfloat-abi=so
