[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94215d2b2103: [clang-format] Correctly annotate star/amp in function pointer params (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay added a comment. I learn a lot from watching the others code review. Definitely not an expert here either, just try to help where I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135707/new/ https://reviews.llvm.org/D135707

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

owenpan added a comment. In D135707#3858097 , @MyDeveloperDay wrote: > Thanks @rymiel its great to have another active contributor, especially one > who seems so focused on github issues. Really appreciate your recent > contributions. Can we start

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

HazardyKnusperkeks added a comment. In D135707#3859357 , @rymiel wrote: > Thanks for the kind words ❤️ (I've noticed Björn already includes me in his > reviewers list); and while I am humbled, and I do look at every patch, I > don't *yet* trust myself

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel added a comment. Thanks for the kind words ❤️ (I've noticed Björn already includes me in his reviewers list); and while I am humbled, and I do look at every patch, I don't *yet* trust myself to actually perform good code review, as it's not something I've really ever done before.

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay added a comment. Thanks @rymiel its great to have another active contributor, especially one who seems so focused on github issues. Really appreciate your recent contributions. Can we start including you as one of the default reviewers that we use to review our stuff?

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135707/new/ https://reviews.llvm.org/D135707

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inside the arguments part of a function