[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw abandoned this revision. sstwcw added a comment. It does some more than D137052 . But the addition stuff is not very important and no one can review it. So I am closing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. I'm lost at this topic. Is this change still needed? Is it superseded by or additional to D137052 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 470016. sstwcw added a comment. - Merge - use ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467833. sstwcw added a comment. - correct spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a comment. In D135740#3858782 , @MyDeveloperDay wrote: > Did you test this with nested #if #endif? No. I added the tests now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467829. sstwcw added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

MyDeveloperDay added a comment. Did you test this with nested #if #endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 ___ cfe-commits mailing list

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. In D135740#3851405 , @sstwcw wrote: > Should I add a test with comments to be aligned like in the bug report? I > was not sure because I didn't find an existing test for alignment of comments. Yes you should.

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a project: clang-format. sstwcw added a comment. Should I add a test with comments to be aligned like in the bug report? I was not sure because I didn't find an existing test for alignment of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2183fe2