This revision was automatically updated to reflect the committed changes.
Closed by commit rGeb3f7880a272: [clang-tblgen][NFC] renames Diagnostic.Text to
Diagnostic.Summary (authored by cjdb).
Changed prior to commit:
https://reviews.llvm.org/D135820?vs=467283=476793#toc
Repository:
rG LLVM
aaron.ballman added a comment.
Please be sure to add `NFC` to the commit message so it's clear why there's no
tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135820/new/
https://reviews.llvm.org/D135820
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM as well!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135820/new/
https://reviews.llvm.org/D135820
___
cfe-commits mailing list
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I'm unopposed. I think the justification isn't particularly clear to me and
doesn't seem discussed in that RFC that I can tell, but I don't really have a
concern here. Give folks a
cjdb updated this revision to Diff 467283.
cjdb added a comment.
undoes an unnessecary change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135820/new/
https://reviews.llvm.org/D135820
Files:
clang/include/clang/Basic/Diagnostic.td
cjdb created this revision.
cjdb added reviewers: aaron.ballman, erichkeane, shafik.
Herald added a subscriber: arphaman.
Herald added a project: All.
cjdb requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The [Improving Clang's Diagnostics
