This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa10eb07d1acc: Do not append terminating NUL to the binary
string with embedded fatbin. (authored by tra).
Repository:
rG LLVM Github Monorepo
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135832/new/
https://reviews.llvm.org/D135832
tra added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:95
llvm::ConstantInt::get(SizeTy, 0)};
-auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str());
+auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str(),
tra updated this revision to Diff 467957.
tra added a comment.
Reworked string/array generation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135832/new/
https://reviews.llvm.org/D135832
Files:
clang/lib/CodeGen/CGCUDANV.cpp
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:95
llvm::ConstantInt::get(SizeTy, 0)};
-auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str());
+auto ConstStr = CGM.GetAddrOfConstantCString(Str,
tra created this revision.
Herald added a subscriber: bixia.
Herald added a project: All.
tra retitled this revision from "Do not append terminating NUL to the binary
string with embedded fatbin." to "Do not append terminating NUL to the string
with embedded GPU binary.".
tra added a reviewer:
