[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04615b695aad: [clang][LTO] Setting Desired Default AIX Debugging Options (authored by Qiongsi Wu qiongs...@gmail.com). Repository: rG LLVM Github

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468525. qiongsiwu1 added a comment. Address a review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:588 +else if (A->getOption().matches(options::OPT_ggdb) || +

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468341. qiongsiwu1 added a comment. Clean up testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589 + // On platforms other than AIX, gdb is the default option. + // On AIX, dbx will be automatically pick up in the presense of the

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468307. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files:

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 added a comment. Ah I just saw 5d3139aef113881fff9430c96069faf96630a5d8 . Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589 + // On platforms other than AIX, gdb is the default option. + // On AIX, dbx will be automatically pick up in the presense of the + // debugger tuning argument, so set gdb

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: shchenz, lkail, w2yehia, daltenty, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision.