[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 added a comment. I'm not sure about that. The failing test isn't using modules and it has failed with the same error before: https://lab.llvm.org/buildbot/#/builders/237/builds/345 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

vitalybuka added subscribers: fmayer, vitalybuka. vitalybuka added a comment. FYI @fmayer Probably this patch https://lab.llvm.org/buildbot/#/builders/237/builds/350/steps/13/logs/stdio -- Testing: 66920 tests, 48 workers -- Testing: 0.. 10.. 20 FAIL: Clang ::

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

This revision was automatically updated to reflect the committed changes. Closed by commit rGf33173acd687: [clang][modules][deps] System module maps might not be affecting (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D136007?vs=467979=472508#toc Repository:

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm once D136624 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136007/new/

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-redefinition.m:37 +// RUN: %clang @%t/third.cc1.rsp +// RUN: %clang @%t/first.cc1.rsp Before this patch, this would fail with duplicate definition of module 'X'. It would be

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 created this revision. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner relies on the module map filtering logic in