[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver abandoned this revision. TWeaver added a comment. Hi all, thanks for your time and effort reviewing this patch. I'm going to close this now due to the lack of interest in it's current form. thanks again and happy coding, Tom CHANGES SINCE LAST ACTION

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver added a comment. Hello all, First of all, thank you so much for your reviews, comments and time. Secondly, I apologise for the late reply. I've be thinking about your statements and I have to somewhat agree. This doesn't catch undefined behaviour, at least by its self. It may help

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

lebedev.ri added a comment. Looks like this and more is already being caught by clang-tidy's google-readability-casting check . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136156/new/ https://reviews.llvm.org/D136156

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

aaron.ballman added a comment. Thank you for the patch! We don't typically add new diagnostics that are ignored by default because we have significant evidence that users don't enable them enough to warrant adding them. In this case, I don't think we should enable this by default because it's