This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4c87e12484b3: Fix crash in constraining partial
specialization on nested template. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136259/new/
https://reviews.llvm.org/D136259
usaxena95 updated this revision to Diff 468962.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136259/new/
https://reviews.llvm.org/D136259
Files:
ilya-biryukov added inline comments.
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5807
bool TraverseTemplateName(TemplateName Template) {
-if (auto *TTP =
-dyn_cast(Template.getAsTemplateDecl()))
- if (TTP->getDepth() == Depth)
-
usaxena95 updated this revision to Diff 468925.
usaxena95 added a comment.
Added test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136259/new/
https://reviews.llvm.org/D136259
Files:
clang/lib/Sema/SemaTemplateDeduction.cpp
usaxena95 created this revision.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes: https://github.com/llvm/llvm-project/issues/53354
Repository:
rG LLVM Github Monorepo
