aaronpuchert added inline comments.
Comment at: clang/lib/Basic/CMakeLists.txt:114-117
+target_link_libraries(clangBasic
+ PRIVATE
+ ${LLVM_ATOMIC_LIB}
+)
Arfrever wrote:
> mgorny wrote:
> > Is this the right place? Grepping for `std::atomic`, I see
This revision was automatically updated to reflect the committed changes.
Closed by commit rG20132d8eaa68: Link libclangBasic against libatomic when
necessary. (authored by thesamesam, committed by mgorny).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I suppose it comes indirectly then. I'd prefer that you tested it with git
main, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Arfrever added inline comments.
Comment at: clang/lib/Basic/CMakeLists.txt:114-117
+target_link_libraries(clangBasic
+ PRIVATE
+ ${LLVM_ATOMIC_LIB}
+)
mgorny wrote:
> Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a
> bunch of
mgorny added inline comments.
Comment at: clang/lib/Basic/CMakeLists.txt:114-117
+target_link_libraries(clangBasic
+ PRIVATE
+ ${LLVM_ATOMIC_LIB}
+)
Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a
bunch of tools, plus a few
thesamesam created this revision.
thesamesam added reviewers: mgorny, MaskRay.
Herald added a subscriber: StephenFan.
Herald added a project: All.
thesamesam requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is necessary at least on
