[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. ouf, thanks :) I am sure the doc has plenty of other issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Jan Kasper via Phabricator via cfe-commits
DerKasper added a comment. No worries and no need to waste time with redoing stuff. I can live without all the fame and perks that come with this highly complex contribiution! ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. yeah, happy to do that if the author wants :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D136424#3874196 , @sylvestre.ledru wrote: > oh, crappy, i forgot to update the author of the patch :( > really sorry about that... :( No worries, it happens (I've made the same mistake a few times as well)! If

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. oh, crappy, i forgot to update the author of the patch :( really sorry about that... :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. pushed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb814d85e5b9d: Update links to googletest documentation (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D136424#3874180 , @DerKasper wrote: > I am not sure, what i have to do now, after this was accepted? > In the documentation i find: > "If you do not have commit access, please let people know during the review > and

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. np, let me land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Jan Kasper via Phabricator via cfe-commits
DerKasper added a comment. In D136424#3873635 , @sylvestre.ledru wrote: > Thanks for carrying about the doc! I am so happy about the functionality of clang and all the tools around, that this is a nice form of giving back something. I am not sure,

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks for carrying about the doc! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424

[PATCH] D136424: Update links to googletest documentation

2022-10-21 Thread Jan Kasper via Phabricator via cfe-commits
DerKasper created this revision. DerKasper added a reviewer: njames93. DerKasper added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. DerKasper requested review of this revision. Herald added a subscriber: cfe-commits. Update links to