[PATCH] D136668: [clang][dataflow] Add initial sign analysis

2022-10-26 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93ce23adb548: [clang][dataflow] Add initial sign analysis (authored by martong). Changed prior to commit:

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

2022-10-26 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 470796. martong marked 2 inline comments as done. martong added a comment. - Address ymandel's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136668/new/ https://reviews.llvm.org/D136668 Files:

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

2022-10-26 Thread Gabor Marton via Phabricator via cfe-commits
martong marked 13 inline comments as done. martong added a comment. In D136668#3883241 , @ymandel wrote: > Nice!! Just nits. > > At a high level, I'm a little concerned about this as a demo, since I > wouldn't recommend this implementation in practice

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

2022-10-25 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice!! Just nits. At a high level, I'm a little concerned about this as a demo, since I wouldn't recommend this implementation in practice (for various reasons, e.g. I would encode with

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

2022-10-25 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: xazax.hun, gribozavr2, sgatev, ymandel. Herald added subscribers: steakhal, rnkovacs. Herald added a reviewer: Szelethus. Herald added a project: All. martong requested review of this revision. Herald added a project: clang. Herald added a