[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added a comment. In D136707#3892300 , @jyknight wrote: > This change has caused `clang -Wall -fdebug-default-version=5 -c -xc > /dev/null -o /dev/null` to print the following warning, because it has moved > the read of the argument into a condit

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

jyknight added a comment. This change has caused `clang -Wall -fdebug-default-version=5 -c -xc /dev/null -o /dev/null` to print the following warning, because it has moved the read of the argument into a conditional. `clang: warning: argument unused during compilation: '-fdebug-default-version=

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad78ce44bb47: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHA

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:979 + unsigned DwarfVersion = GetDwarfVersion(getToolChain(), Args); + std::string DV = "-gdwarf-" + std::to_string(DwarfVersion); + CmdArgs.push_back(Args.MakeArgString(DV)); --

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers updated this revision to Diff 470860. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - add const, fix lowerCamelCase, use Twine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136707/new/ https://re

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7966 } + unsigned DwarfVersion = GetDwarfVersion(getToolChain(), Args); RenderDebugEnablingArgs(Args, CmdArgs, DebugInfoKind, DwarfVersion, Consider `const` if this variable i

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers updated this revision to Diff 470638. nickdesaulniers added a comment. - more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136707/new/ https://reviews.llvm.org/D136707 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:107 unsigned ParseDebugDefaultVersion(const ToolChain &TC, const llvm::opt::ArgList &Args); This can be made static to the .cpp file

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4206-4214 // If a -gdwarf argument appeared, remember it. const Arg *GDwarfN = getDwarfNArg(Args); bool EmitDwarf = false; if (GDwarfN) { if (checkDebugInfoOption(GDwarfN, Ar

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, probinson. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've been worki