[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rGbeb997799d82: [Clang] Improve diagnostic message for loop hint pragma (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https:/

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471344. eopXD added a comment. Update code to handle when IdentifierInfo is null. The .Case syntax seems to evaulate expression in other non-trigger cases. The "loop" case was triggered for test case in loop unroll and jam, resulting in segmentation fault. Anywa

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); std::string ClangLoopStr = (llvm::Twine("clang

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471057. eopXD marked an inline comment as done. eopXD added a comment. Update code based on suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/l

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName()).str(); eopXD

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471048. eopXD added a comment. Rebase upon latest main and simplify existing checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragm

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

SjoerdMeijer added a reviewer: fhahn. SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->ge