[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31f4859c3e4d: [Clang] Allow additional mathematical symbols in identifiers. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 482778. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:129-130 InGroup>; def warn_utf8_symbol_homoglyph : Warning< "treating Unicode character as identifier character rather than " "as '%1' symbol">, InGroup>;

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. Thanks Tom. I'm adding more reviewers in case someone else wants to look at it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 481556. cor3ntin added a comment. Fix grammar in diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. In D137051#3982833 , @tahonermann wrote: > Oh, also, the review summary mentions "UAX32" (twice); those should be > "UAX31". Just please make sure the commit message is correct. > > Also, I'm terribly sorry for being so slow

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann added a comment. Oh, also, the review summary mentions "UAX32" (twice); those should be "UAX31". Just please make sure the commit message is correct. Also, I'm terribly sorry for being so slow to get this reviewed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks great to me. I added a minor comment regarding the grammar of the added diagnostic, but am accepting the review regardless. Comment at:

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann added a comment. I apologize for the delay Corentin, I hope to get through a number of my outstanding code reviews tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 471882. cor3ntin added a comment. Remove extra semi colon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. Note that we should wait end of next week to hear back from the Unicode Technical Committee before merging this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement the proposed UAX Profile "Mathematical notation profile for default identifiers". This implements a not-yet