[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

2022-10-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D137077#3896561 , @merrymeerkat wrote: > In D137077#3896369 , @aaron.ballman > wrote: > >> Thank you for the patch! However, I think this isn't an improvement to the >>

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

2022-10-31 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
merrymeerkat added a comment. In D137077#3896369 , @aaron.ballman wrote: > Thank you for the patch! However, I think this isn't an improvement to the > diagnostic -- it's a cute phrase, but it doesn't help the programmer to > understand what about

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

2022-10-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for the patch! However, I think this isn't an improvement to the diagnostic -- it's a cute phrase, but it doesn't help the programmer to understand what

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

2022-10-31 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td