Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

2015-10-14 Thread Eric Fiselier via cfe-commits
EricWF added a comment. - I would love to have some documentation in libc++ about always-inline, the ABI problem it is trying to solve, and how it falls short. Because you tried to fix these semantics in clang would you be willing to write up a short summary of when always-inline does and

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

2015-10-14 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. I've wrote down my understanding of the problem in ABIVersioning.rst. AFAIK, Howard added the attribute so he might know more about it. Why does windows need this attributes in the unstable abi build? Hidden visibility and always_inline work together for the same goal,

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

2015-10-14 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 37427. Repository: rL LLVM http://reviews.llvm.org/D13713 Files: docs/DesignDocs/ABIVersioning.rst include/__config Index: include/__config === --- include/__config +++ include/__config

[PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

2015-10-13 Thread Evgeniy Stepanov via cfe-commits
eugenis created this revision. eugenis added reviewers: mclow.lists, EricWF. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Herald added a subscriber: aemerson. ABI stability is not an issue when building for unstable ABI. Other than that,