[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay added a comment. In D137227#3909056 , @sbc100 wrote: >> The asan instrumentation just prepends `__odr_asan_gen_` to the symbol name >> to form a new symbol name. For ELF every byte except `\0` can be used in a >> symbol name, and this is totally

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. > The asan instrumentation just prepends `__odr_asan_gen_` to the symbol name > to form a new symbol name. For ELF every byte except `\0` can be used in a > symbol name, and this is totally fine. > > I am unfamiliar with WebAssembly. Does the aforementioned parsing tool

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay added a comment. In D137227#3908994 , @sbc100 wrote: > At least for WebAssembly object files, it looks like the symbol table now > contains (what look like) demangled symbols. e.g.: > > $ llvm-nm /tmp/emscripten_temp/command_0.o > 3ef5

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. At least for WebAssembly object files, it looks like the symbol table now contains (what look like) demangled symbols. e.g.: $ llvm-nm /tmp/emscripten_temp/command_0.o 3ef5 D __odr_asan_gen__numargs 41a6 D __odr_asan_gen__stdcmd<1068>::init 41c3 D __

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ada819c237b: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows (authored by MaskRay). Repository: rG LLVM Github Monorepo C

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay updated this revision to Diff 472827. MaskRay marked 2 inline comments as done. MaskRay added a comment. address comments Thanks for the quick review:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137227/new/ https://reviews.llvm.org/D137

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:777 // Enable aliases as they should have no downside with ODR indicators. -UsePrivateAlias(UseOdrIndicator || ClUsePrivateAlias), -UseOdrIndicator(UseO

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll:8 ; -; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S | Fil

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay updated this revision to Diff 472533. MaskRay retitled this revision from "[asan] Default to -fsanitize-address-use-odr-indicator" to "[asan] Default to -fsanitize-address-use-odr-indicator for non-Windows". MaskRay edited the summary of this revision. MaskRay added a comment. Herald adde