[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. In D137268#4069992 , @zatrazz wrote: > Could you check if this fixes your issue? yes, thanks... the person doing the llvm update tried it and reports that it works. here's the patch against our old copy of glibc:

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069935 , @enh wrote: > In D137268#4069856 , @zatrazz wrote: > >> I think I have caught this because your standard conformance tests checks >> for __gnuc_va_list >> on

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. In D137268#4069856 , @zatrazz wrote: > I think I have caught this because your standard conformance tests checks for > __gnuc_va_list > on wchar.h, wich is always defined on on GCC (git log shows it was changed to > fix XPG7 >

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069779 , @enh wrote: > is there a corresponding glibc change so that `va_list` is exported for > `_POSIX_SOURCE` cases? see > https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where > i'm

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. is there a corresponding glibc change so that `va_list` is exported for `_POSIX_SOURCE` cases? see https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where i'm having to disable some bionic testing against glibc because the glibc (2.17!) now no longer

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz updated this revision to Diff 474028. zatrazz marked 2 inline comments as done. zatrazz added a comment. Update review based on reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; MaskRay wrote: > To match gcc stdarg.h, `#define

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. LGTM, but changes are needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

MaskRay added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; To match gcc stdarg.h, `#define __GNUC_VA_LIST` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

efriedma added inline comments. Comment at: clang/lib/Headers/stdarg.h:21 + +#ifdef __STDARG_H Maybe the following is a little more readable? ``` #ifndef __STDARG_H #ifndef __GNUC_VA_LIST #define __GNUC_VA_LIST 1 typedef __builtin_va_list __gnuc_va_list;

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. The glibc uses