Mordante added a comment.
Herald added subscribers: bviyer, jplehr.
For libc++ we like to clean up the review queue for the GitHub PR transition.
Is there still interest on working on this patch? If so would it be possible to
finish it before the Phabricator is changed to read only mode?
barannikov88 added inline comments.
Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17
-#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@"
+#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@"
barannikov88 wrote:
> The prefix must
barannikov88 added inline comments.
Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17
-#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@"
+#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@"
The prefix must remain LLVM_*
In other
compnerd added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);
if
Ericson2314 added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);
compnerd added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);
if
serge-sans-paille added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath,
Ericson2314 added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);
tianshilei1992 added a comment.
Can you verify if projects enabled by `LLVM_ENABLE_RUNTIMES` (not
`LLVM_ENABLE_PROJECTS`) will still be installed properly, aka in LLVM's lib
directory?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137337/new/
https://reviews.llvm.org/D137337
mgorny added inline comments.
Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32
SmallString<128> LibPath = llvm::sys::path::parent_path(Dir);
- llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX);
+ llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);
if
serge-sans-paille updated this revision to Diff 472945.
serge-sans-paille added a comment.
+ Release Note
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137337/new/
https://reviews.llvm.org/D137337
Files:
bolt/CMakeLists.txt
sylvestre.ledru added a comment.
Maybe add it to the release notes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137337/new/
https://reviews.llvm.org/D137337
___
cfe-commits mailing list
serge-sans-paille created this revision.
serge-sans-paille added reviewers: MaskRay, tstellar, mgorny, sylvestre.ledru.
Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178,
Enna1, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, cota,
StephenFan, teijeong,
13 matches
Mail list logo
