[PATCH] D137338: Fix dupe word typos

Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..) Add your unit tests in `c

[PATCH] D137338: Fix dupe word typos

ldionne added a comment. Herald added subscribers: wangpc, gysit, Dinistro, hoy, bviyer, wlei, jplehr, PiotrZSL, luke, sunshaoce. Herald added a reviewer: springerm. Herald added a reviewer: kiranchandramohan. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks

[PATCH] D137338: Fix dupe word typos

thakis added inline comments. Herald added a reviewer: njames93. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47 // complete architecture list, nor a reasonable subset. The problem is that - // historically the driver driver accepts this and also ties its -march= //

[PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. I landed the Clang bits in 94738a5ac34283bb034b022602b9f9e93d67081f , thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1373

[PATCH] D137338: Fix dupe word typos

kadircet added a comment. LGTM for changes under `clang-tools-extra/clangd` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-com

[PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. In D137338#3912135 , @aaron.ballman wrote: > In D137338#3907281 , @Rageking8 > wrote: > >> I am ok with you guys taking the parts of this revision that you reviewed >> and directly co

[PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. In D137338#3907281 , @Rageking8 wrote: > I am ok with you guys taking the parts of this revision that you reviewed and > directly commiting them to the repo, just like how the person above did it. > This is to break the re

[PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. I am ok with you guys taking the parts of this revision that you reviewed and directly commiting them to the repo, just like how the person above did it. This is to break the revision up to smaller parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D137338: Fix dupe word typos

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341 if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { - // Handle C++ base classes. Non-virtual bases can treated a a kind of + // Handle C++ base classes. Non-virtual bases can treat

[PATCH] D137338: Fix dupe word typos

curdeius added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341 if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { - // Handle C++ base classes. Non-virtual bases can treated a a kind of + // Handle C++ base classes. Non-virtual bases can treated a

[PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. The clang parts generally LG, but I spotted a few things. Thank you for this cleanup effort! Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:467 - /// Return a matcher that that points to the same implementation, but sets th

[PATCH] D137338: Fix dupe word typos

int3 added a comment. lld/MachO changes lgtm Comment at: lld/MachO/Driver.cpp:1386 // ld64 does something really weird. It attempts to realign the value to the -// page size, but assumes the the page size is 4K. This doesn't work with +// page size, but assumes th

[PATCH] D137338: Fix dupe word typos

Amir accepted this revision. Amir added a comment. BOLT changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137338: Fix dupe word typos

sivachandra accepted this revision. sivachandra added a comment. Changes in the libc directory LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-com

[PATCH] D137338: Fix dupe word typos

tianshilei1992 added a comment. Changes to `openmp` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137338: Fix dupe word typos

DavidSpickett added a comment. Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead. As others said, appreciate the effort but the review process doesn't scale well t

[PATCH] D137338: Fix dupe word typos

ldionne accepted this revision. ldionne added a comment. Thanks for the fixes. LGTM for `libcxx/`, `libcxxabi/` and `libunwind/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 __

[PATCH] D137338: Fix dupe word typos

aartbik added a comment. LGTM for sparse changes (note that you could have made your life a bit easier if you had broken this revision up at least over different projects, getting a global "LGTM" from somebody may be a bit hard now ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D137338: Fix dupe word typos

foad added a comment. I committed the lib/Target/AMDGPU parts as 5073ae2a883f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 __

[PATCH] D137338: Fix dupe word typos

glider added subscribers: pcc, glider. glider added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:54 - /// Returns whether the given label label contains the label elem. + /// Returns whether the given label contains the label elem. int dfsan_has_labe

[PATCH] D137338: Fix dupe word typos

jhenderson added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere. This is going to be impossible to cleanly review as-is. Could it be broken into lots of smaller chunks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION