[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

2022-11-04 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Thanks for this patch! Unfortunately, I'm having trouble following the change. Can you expand the description to give a more detailed explantion of the motivation and the key point that are changing? Unfortunately, I don't understand the motivation for the new API

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

2022-11-04 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h:35 +public: + CFGMatchSwitch(std::unique_ptr CurrentElement, + ASTMatchSwitch StmtMS, Why do we need to keep this pointer on the heap?

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement.

2022-11-04 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, previously, if the