courbet marked an inline comment as done.
courbet added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:294
+- Improved :doc:`bugprone-fold-init-type
+ ` to handle iterators that do not
Eugene.Zelenko wrote:
> Please keep alphabetical
Eugene.Zelenko added a comment.
Please rebase from latest `main`.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:294
+- Improved :doc:`bugprone-fold-init-type
+ ` to handle iterators that do not
Please keep alphabetical order (by check name) in this
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1012677284b8: [clang-tidy]bugprone-fold-init-type (authored
by courbet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
courbet added a comment.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
courbet updated this revision to Diff 511634.
courbet added a comment.
Fix release note placement and phrase it more consistenly with other notes in
that section.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
PiotrZSL added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:101
+- :doc:`bugprone-fold-init-type
+ ` now handles iterators that do
not
Wrong section, this should be in 'Changes in existing checks'
Repository:
rG LLVM Github
courbet updated this revision to Diff 511424.
courbet marked 2 inline comments as done.
courbet added a comment.
- Address review comments
- Add release notes.
Thanks !
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
PiotrZSL added a comment.
Missing ReleaseNotes,
Comment at: clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp:41
+returns(hasCanonicalType(
+referenceType(pointee(BuiltinTypeWithId(ID),
+//
courbet added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
courbet added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
courbet updated this revision to Diff 474548.
courbet added a comment.
remove extra training newline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
Files:
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/fold-init-type.cpp:205
}
+
Excessive newline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
courbet updated this revision to Diff 474520.
courbet added a comment.
fix typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137782/new/
https://reviews.llvm.org/D137782
Files:
clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp
courbet created this revision.
courbet added a reviewer: aaron.ballman.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
courbet requested review of this revision.
Herald added a project: clang-tools-extra.
Handle iterators that
15 matches
Mail list logo
