sbenza accepted this revision.
sbenza added a comment.
This revision is now accepted and ready to land.
Seems straightforward.
http://reviews.llvm.org/D13784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250537: [clang-tidy] add check
cppcoreguidelines-pro-type-union-access (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D13784?vs=37515=37621#toc
Repository:
rL LLVM
sbenza added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.cpp:20
@@ +19,3 @@
+void ProTypeUnionAccessCheck::registerMatchers(MatchFinder *Finder) {
+
mgehre marked an inline comment as done.
mgehre added a comment.
http://reviews.llvm.org/D13784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
This check flags all access to members of unions. Passing unions as a
whole is not flagged.
Reading from a union member assumes that member was the last one