[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgraenitz marked an inline comment as done. Closed by commit rGd9eece916a8a: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet… (authored

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:597 + assert(CV.size() > 0 && "Uncolored block"); + for (BasicBlock *EHPadBB : CV) +if (auto *EHPad =

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. I'm not familiar with the WinEH stuff, but the other parts (the code that adds bundles, etc.) LGTM. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:597 +

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. This review belongs to a series of patches. I am planning to land it towards the end of next week, so that it's ready for the next release branching in February. If you have any more remarks, please let me know soon. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Thanks for taking a look. That' really useful feedback! Yes, the coloring can be expensive and we shouldn't run it more than once. and there's more places indeed until it either stops making changes or // no retain+release pair nesting is detected

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 483745. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 Files:

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

ahatanak added inline comments. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector = BlockColors.find(BB)->second; +assert(CV.size() == 1 && "non-unique color for block!"); +BasicBlock *EHPadBB = CV.front(); sgraenitz

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. This is ready to land and I'd appreciate feedback from one of the authors. Anyone else I should add for review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477471. sgraenitz added a comment. Handle potential multi-color basic blocks in addOpBundleForFunclet() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944 Files:

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz updated this revision to Diff 477470. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rebase and update check-lines after D137939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Thanks for your feedback @rnk! I hope some of the ObjCARCOpts authors will share their opinions as well. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector = BlockColors.find(BB)->second; +assert(CV.size() == 1

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

rnk added a comment. I can't say I'm familiar with ARC, but this seems right to me. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector = BlockColors.find(BB)->second; +assert(CV.size() == 1 && "non-unique color for block!"); +BasicBlock

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. There doesn't seem to be a 1-to-1 relationship between deleted and inserted retain/release calls and thus we don't attempt to preserve bundle operands in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. There was a similar effort for CleanupPads in the past: https://reviews.llvm.org/rG8b342680bf62722e5099074e8bd23491c71d92b3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz created this revision. sgraenitz added reviewers: gottesmm, rjmccall, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. When optimizing