[PATCH] D137995: [Flang][Driver] Handle target CPU and features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3951a73490df: [Flang][Driver] Handle target CPU and features (authored by mnadeem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/ https://reviews.llvm.org/D137995 ___ cfe-commits

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem updated this revision to Diff 479474. mnadeem marked 4 inline comments as done. mnadeem added a comment. - Address comments. - Add fc1 tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/ https://reviews.llvm.org/D137995 Files:

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

awarzynski added a comment. Thanks for all the updates @mnadeem! Mostly looks good. A few more nits, but nothing substantial :) In D137995#3958824 , @mnadeem wrote: > In D137995#3931005 , > @kiranchandramohan

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:99 + default: +// Untested for other targets but should work generally. +break; mnadeem wrote: > kiranchandramohan wrote: > > I get a segfault in ` > >

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:99 + default: +// Untested for other targets but should work generally. +break; kiranchandramohan wrote: > I get a segfault in `

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added a comment. In D137995#3931005 , @kiranchandramohan wrote: > We might need `-fc1` tests as well. What kind of tests do you think would be appropriate here? Can you point me to any examples, maybe from clang? CHANGES SINCE LAST ACTION

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added a comment. In D137995#3944145 , @awarzynski wrote: > Thanks for implementing this! > >> Processes target cpu and features in the flang driver. Right now features >> are only added for AArch64 because I only did basic testing on AArch64

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem updated this revision to Diff 478766. mnadeem marked 4 inline comments as done. mnadeem edited the summary of this revision. Herald added a subscriber: pengfei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/ https://reviews.llvm.org/D137995 Files:

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

awarzynski added a comment. Thanks for implementing this! > Processes target cpu and features in the flang driver. Right now features are > only added for AArch64 because I only did basic testing on AArch64 but it > should generally work for others as well. X86 is a very popular target and we

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

kiranchandramohan added a comment. Thanks @mnadeem for this patch. A few minor comments first. Try to replace auto in all places except where the type is on the RHS. We might need `-fc1` tests as well. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:85 +

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem created this revision. mnadeem added reviewers: vzakhari, awarzynski, kiranchandramohan. mnadeem added a project: Flang. Herald added subscribers: ctetreau, jdoerfert, s.egerton, simoncook, fedor.sergeev, kristof.beyls, dschuff. Herald added a reviewer: sscalpone. Herald added a project: