[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG77a38f43b168: [clang-format] Supress aligning of trailing namespace comments (authored by

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); + Nit.

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#4535269 , @MyDeveloperDay wrote: > In D138263#3936536 , > @HazardyKnusperkeks wrote: > >> In D138263#3936007 , @owenpan

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

MyDeveloperDay added a comment. In D138263#3936536 , @HazardyKnusperkeks wrote: > In D138263#3936007 , @owenpan wrote: > >> I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, >> then

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 543918. HazardyKnusperkeks marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:3137 +"} // namespace C\n" +" }// TESTSUITE(B)\n" +"} // NaMeSpAcE A",

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2976-2977 +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); +

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 541959. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. I'll wait for the revert and then look how to go forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. In D138263#3975828 , @owenpan wrote: > Can you rebase (preferably after landing D138402 > )? See D139257#3983332 . If it gets reverted, we have to do

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool WasAlignedWithStartOfNextLine = false; owenpan wrote: >

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. Can you rebase (preferably after landing D138402 )? Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3938593 , @owenpan wrote: > Something like the following: > > diff --git a/clang/lib/Format/FormatToken.h b/clang/lib/Format/FormatToken.h > index 87515372046d..3dc5e411df55 100644 > ---

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 476722. HazardyKnusperkeks added a comment. Now with the annotated paren. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. Something like the following: diff --git a/clang/lib/Format/FormatToken.h b/clang/lib/Format/FormatToken.h index 87515372046d..3dc5e411df55 100644 --- a/clang/lib/Format/FormatToken.h +++ b/clang/lib/Format/FormatToken.h @@ -98,6 +98,8 @@ namespace format {

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. In D138263#3937223 , @HazardyKnusperkeks wrote: > In D138263#3936536 , > @HazardyKnusperkeks wrote: > >> In D138263#3936007 , @owenpan >>

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. Working on the annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936536 , @HazardyKnusperkeks wrote: > In D138263#3936007 , @owenpan wrote: > >> I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, >>

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936007 , @owenpan wrote: > I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, > then wouldn't it be better to do that? But the `r_brace` has no `MatchingParen`, and I didn't want

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, then wouldn't it be better to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a