[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-12-05 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. Landed at: https://reviews.llvm.org/rGbb5bcddcdbc151119f449be2d1e0d90f2e9c4258. Forgot to add the "Revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138326/new/ https://reviews.llvm.org/D138326

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-11-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk resigned from this revision. rnk added a comment. Seems right to me, but I would prefer if someone else can review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138326/new/ https://reviews.llvm.org/D138326

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-11-18 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. In D138326#3938128 , @rnk wrote: > Since Clang creates the member list and only adds types for the benefit of > codeview, should we change clang instead? Yes, that's something clang does only for codeview, changed in clang

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-11-18 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 476621. zequanwu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reverted previous change and change clang side so that it doesn't emit nested anonymous record type when emitting code-view. Repository: rG LLVM