[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

dyung added a comment. @serge-sans-paille, one of our internal tests hit an assertion failure which I bisected back to your change. I have filed issue 59321 with a repro. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

tschuett added a comment. error: comparison of integers of different signs: 'long' and 'unsigned long' [-Werror,-Wsign-compare] if (End - Start > sizeof(Word)) { Comment at: clang/lib/Basic/SourceManager.cpp:1292 // This is much faster than scanning each byte

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGf607884a04b0: [clang] Speedup LineOffsetMapping::get (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://reviews.llvm.org/D138474

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

serge-sans-paille added a comment. Gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://reviews.llvm.org/D138474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic, lattner. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LineOffsetMapping::get is a critical