[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc73876db4f2d: Reapply DebugInfo: Add/support new DW_LANG codes for recent C and C++… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D138597?vs=480590=482273#toc Repository:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie reopened this revision. dblaikie added a comment. This revision is now accepted and ready to land. (just a side note I discovered while looking into this: seems someone else had this idea before & came to similar conclusions: https://reviews.llvm.org/D104118#2840490 ) Repository:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Oh, right, PS4 defaults to C99. It's okay with me if you make those two unsupported for PS4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. LGTM. I agree with the commentary in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c312e48f325: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions (authored by dblaikie). Changed prior to commit:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This minimal patch LGTM. Comment at: llvm/lib/IR/DIBuilder.cpp:159 - assert(((Lang <= dwarf::DW_LANG_Fortran08 && Lang >= dwarf::DW_LANG_C89) || + assert(((Lang <=

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. In D138597#3966638 , @probinson wrote: > One not-yet-asked question, does gcc produce the C++17/20 codes? If so, does > fstrict-dwarf affect that? Looks like GCC uses C++17 for both 17 and 20:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 480296. dblaikie added a comment. Don't use the since-v5-published codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 480292. dblaikie added a comment. Rebase on top of committed LLVM changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl added a comment. Agreeing with @probinson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. One not-yet-asked question, does gcc produce the C++17/20 codes? If so, does fstrict-dwarf affect that? The major consumers of this would be lldb (which we control) and gdb, so following gcc's lead here would seem appropriate. I can accept that listing the codes on

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. Don't know that I've got it in me right now to do the more invasive change of updating the LLVM DebugInfo IR metadata to carry the DWARFv6 style language+version stuff (perhaps especially if that's going to go alongside the DWARFv5 and earlier pure language encoding)

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 479499. dblaikie added a comment. Add llvm testing (but I'm going to rework this a lot, so this is just a snapshot for history) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl added a comment. > @aprantl do you have an opinion on this? I tend to lean to the pedantic side > on this kind of thing, but I'm persuadable. As long as LLDB can deal with it I'm fine either way. Emitting the separated DWARF 6 attribute as an extension sounds fine to me.

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. > They're published on the website too: https://dwarfstd.org/LanguagesV6.php (sigh) sorry, distracted by other things today. Yeah, using the v6 codes with the v6 attributes for the new ones WFM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. >>> @aprantl do you have an opinion on this? I tend to lean to the pedantic >>> side on this kind of thing, but I'm persuadable. >> >> Yeah, I've certainly got mixed feelings - maybe we don't pick up these >> after-release language codes, and instead produce the new

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. In D138597#3957356 , @dblaikie wrote: > In D138597#3954269 , @probinson > wrote: > >> The codes have been allocated but AFAICT the website doesn't have the new >> codes listed (I

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. In D138597#3954269 , @probinson wrote: > Hmmm I might be inclined to emit 17 and 20 only under not-strict-DWARF for > v5, although it makes the logic more complicated. The codes have been > allocated but AFAICT the website

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Hmmm I might be inclined to emit 17 and 20 only under not-strict-DWARF for v5, although it makes the logic more complicated. The codes have been allocated but AFAICT the website doesn't have the new codes listed (I looked at

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie created this revision. dblaikie added reviewers: aprantl, probinson. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. dblaikie requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: