This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10d183b889da: [include-cleaner] Capture private headers in
PragmaIncludes. (authored by VitaNuo, committed by hokein).
Repository:
rG LLVM Github
VitaNuo updated this revision to Diff 478148.
VitaNuo added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo updated this revision to Diff 478145.
VitaNuo marked an inline comment as done.
VitaNuo added a comment.
Address the remaining comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, looks good from my side, a few nits on the test.
Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:364
+
VitaNuo updated this revision to Diff 477960.
VitaNuo added a comment.
Apply the local changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo updated this revision to Diff 477958.
VitaNuo added a comment.
Fix history.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo updated this revision to Diff 477956.
VitaNuo marked 2 inline comments as done.
VitaNuo added a comment.
Fix build.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo marked an inline comment as done.
VitaNuo added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:237
+ auto *FE = SM.getFileEntryForID(SM.getFileID(Range.getBegin()));
+ if (!FE) {
+return false;
kadircet
VitaNuo updated this revision to Diff 477954.
VitaNuo added a comment.
Small refactoring.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:237
+ auto *FE = SM.getFileEntryForID(SM.getFileID(Range.getBegin()));
+ if (!FE) {
+return false;
nit: you can drop the braces here. LLVM convention
VitaNuo updated this revision to Diff 477946.
VitaNuo added a comment.
Fix comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo updated this revision to Diff 477944.
VitaNuo marked an inline comment as done.
VitaNuo added a comment.
Fix build.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo marked 4 inline comments as done.
VitaNuo added a comment.
The formatting has introduced a bit of unrelated diff. It's not much, so I hope
that's fine.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:95
+ /// Contains all files
VitaNuo updated this revision to Diff 477940.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:97
+ /// the IWYU private pragmas with public mapping.
+ llvm::DenseSet IWYUPrivate;
+
i'd actually merge this with the previous map, and
hokein added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:76
+ /// Returns true if the given file is marked with the IWYU private pragma
+ /// without public mapping.
+ bool isPrivate(const FileEntry *File) const;
VitaNuo updated this revision to Diff 477876.
VitaNuo added a comment.
Fix formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo updated this revision to Diff 477874.
VitaNuo added a comment.
Herald added a subscriber: kadircet.
Improve the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138678/new/
https://reviews.llvm.org/D138678
Files:
VitaNuo created this revision.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Save file IDs of IWYU private headers and report them as private.
Repository:
rG LLVM Github Monorepo
19 matches
Mail list logo
